Hi Greg, On 2018/11/22 18:24, Greg Kroah-Hartman wrote: >> + /* lock all primary followed works before visible to others */ >> + if (unlikely(!mutex_trylock(&work->lock))) >> + /* for a new workgroup, try_lock *never* fails */ >> + DBG_BUGON(1); > Again, drop this, if it never fails, then there's no need for this. If > it can fail, then properly handle it. > > And trylock can fail, so this needs to be fixed.
OK, I will drop this. Thanks, Gao Xiang > > thanks, _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
