> -----Original Message-----
> From: linux-kernel-ow...@vger.kernel.org <linux-kernel-ow...@vger.kernel.org> 
> On Behalf
> Of Arvind Yadav
> Sent: Saturday, March 17, 2018 11:48 PM
> To: Stephen Hemminger <sthem...@microsoft.com>; Haiyang Zhang
> <haiya...@microsoft.com>
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org
> Subject: [PATCH] vmbus: use put_device() if device_register fail
> 
> if device_register() returned an error. Always use put_device()
> to give up the reference initialized.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>

Reviewed-by: Michael Kelley <mikel...@microsoft.com>

> ---
>  drivers/hv/vmbus_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index bc65c4d..25da2f3 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1358,6 +1358,7 @@ int vmbus_device_register(struct hv_device 
> *child_device_obj)
>       ret = device_register(&child_device_obj->device);
>       if (ret) {
>               pr_err("Unable to register child device\n");
> +             put_device(&child_device_obj->device);
>               return ret;
>       }
> 
> --
> 2.7.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to