On Mon, Feb 26, 2018 at 10:02:00PM +0530, Ajay Singh wrote: > Fix 'line over 80 character' issue found by checkpatch.pl script. > Refactor wilc_wlan_handle_rxq() code to remove the checkpatch.pl > warnings. > > Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> > --- > drivers/staging/wilc1000/wilc_wlan.c | 46 > ++++++++++++++++++++---------------- > 1 file changed, 25 insertions(+), 21 deletions(-) > > diff --git a/drivers/staging/wilc1000/wilc_wlan.c > b/drivers/staging/wilc1000/wilc_wlan.c > index 74b80ad..223bf8b 100644 > --- a/drivers/staging/wilc1000/wilc_wlan.c > +++ b/drivers/staging/wilc1000/wilc_wlan.c > @@ -798,6 +798,7 @@ static void wilc_wlan_handle_rxq(struct wilc *wilc) > u32 header; > u32 pkt_len, pkt_offset, tp_len; > int is_cfg_packet; > + int tmp; >
Heh. Nope. Don't do this. You've just create a "tmp" variable to hold many different types of random long values... It makes the code less readable. Just break it up into separate functions. regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
