From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Thu, 24 Aug 2017 22:32:14 +0200

Return directly without using an intermediate local variable
in these functions.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/vme/vme.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index a2e36e6a0d84..986799d64993 100644
--- a/drivers/vme/vme.c
+++ b/drivers/vme/vme.c
@@ -1996,28 +1996,26 @@ static int vme_bus_match(struct device *dev, struct 
device_driver *drv)
 
 static int vme_bus_probe(struct device *dev)
 {
-       int retval = -ENODEV;
        struct vme_driver *driver;
        struct vme_dev *vdev = dev_to_vme_dev(dev);
 
        driver = dev->platform_data;
        if (driver->probe)
-               retval = driver->probe(vdev);
+               return driver->probe(vdev);
 
-       return retval;
+       return -ENODEV;
 }
 
 static int vme_bus_remove(struct device *dev)
 {
-       int retval = -ENODEV;
        struct vme_driver *driver;
        struct vme_dev *vdev = dev_to_vme_dev(dev);
 
        driver = dev->platform_data;
        if (driver->remove)
-               retval = driver->remove(vdev);
+               return driver->remove(vdev);
 
-       return retval;
+       return -ENODEV;
 }
 
 struct bus_type vme_bus_type = {
-- 
2.14.0

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to