On Tue, May 23, 2017 at 09:32:13PM +0200, Raphaël Beamonte wrote:
> Fixes the following sparse warnings:
>
> drivers/staging/lustre/lustre/llite/xattr.c:89:62: warning: Variable
> length array is used.
> drivers/staging/lustre/lustre/llite/xattr.c:366:62: warning: Variable
> length array is used.
>
> Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/xattr.c | 24 ++++++++++++++++++++----
> 1 file changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/xattr.c
> b/drivers/staging/lustre/lustre/llite/xattr.c
> index 6187bffec8c4..ccfc728d8ec0 100644
> --- a/drivers/staging/lustre/lustre/llite/xattr.c
> +++ b/drivers/staging/lustre/lustre/llite/xattr.c
> @@ -86,7 +86,7 @@ ll_xattr_set_common(const struct xattr_handler *handler,
> const char *name, const void *value, size_t size,
> int flags)
> {
> - char fullname[strlen(handler->prefix) + strlen(name) + 1];
> + char *fullname;
> struct ll_sb_info *sbi = ll_i2sbi(inode);
> struct ptlrpc_request *req = NULL;
> const char *pv = value;
> @@ -140,10 +140,18 @@ ll_xattr_set_common(const struct xattr_handler *handler,
> return -EPERM;
> }
>
> + fullname = kmalloc(strlen(handler->prefix) + strlen(name) + 1,
> + GFP_KERNEL);
> + if (!fullname)
> + return -ENOMEM;
> +
> sprintf(fullname, "%s%s\n", handler->prefix, name);
> rc = md_setxattr(sbi->ll_md_exp, ll_inode2fid(inode),
> valid, fullname, pv, size, 0, flags,
> ll_i2suppgid(inode), &req);
> +
> + kfree(fullname);
Didn't we reject much this same patch last week?
thanks,
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
