On Sat, 2017-04-22 at 16:26 +0100, Eric Curtin wrote:
> checkpatch spits out a warning about the 80 character line limit. Split
> the parameters of these functions onto different lines. Put the ; with
> the macro caller instead. Lined up parameters as there was another
> CHECK warning about that.
[]
> diff --git a/drivers/staging/fbtft/fbtft-bus.c 
> b/drivers/staging/fbtft/fbtft-bus.c
[]
> @@ -24,7 +24,14 @@ void func(struct fbtft_par *par, int len, ...)             
>                    \
>                       buf[i] = (type)va_arg(args, unsigned int);            \
>               }                                                             \
>               va_end(args);                                                 \
> -             fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, 
> type, buf, len, "%s: ", __func__);   \
> +             fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER,                       \
> +                               par,                                        \
> +                               par->info->device,                          \
> +                               type,                                       \
> +                               buf,                                        \
> +                               len,                                        \
> +                               "%s: ",                                     \
> +                               __func__);                                  \
>       }                                                                     \

Multiple arguments per line please before 80 columns

                fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,                  \
                                  par->info->device, type, buf, len,          \
                                  "%s: ", __func__);                          \

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to