On Thu, Mar 30, 2017 at 12:11:05AM +0300, aviyae wrote:
> Fix style issues by adding parenthesis around macros
> arguments
>
> Signed-off-by: Aviya Erenfeld <aviya...@gmail.com>
> ---
> drivers/staging/goldfish/goldfish_audio.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/goldfish/goldfish_audio.c
> b/drivers/staging/goldfish/goldfish_audio.c
> index bd55995..2bb1f27 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -61,10 +61,11 @@ struct goldfish_audio {
> #define COMBINED_BUFFER_SIZE ((2 * READ_BUFFER_SIZE) + \
> (2 * WRITE_BUFFER_SIZE))
>
> -#define AUDIO_READ(data, addr) (readl(data->reg_base + addr))
> -#define AUDIO_WRITE(data, addr, x) (writel(x, data->reg_base + addr))
> +#define AUDIO_READ(data, addr) (readl((data)->reg_base + (addr)))
> +#define AUDIO_WRITE(data, addr, x) (writel(x, (data)->reg_base + (addr)))
> #define AUDIO_WRITE64(data, addr, addr2, x) \
> - (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base +
> addr2))
> + (gf_write_dma_addr((x), (data)->reg_base + (addr), \
> + (data)->reg_base + (addr2)))
Your indentation here is odd, please fix up.
And is this really a needed change?
thanks,
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
