Function tx_device_task() is a candidate for refactoring. Checkpatch emits a number of warnings/checks for this function.
Patch 01 inverts if statement conditional and reduces the level of nesting. Patch 02 renames rc -> ret, fixes function call and checkpatch WARNING. Patch 03 fixes function argument alignment, and checkpatch CHECK. Code is untested. Patch set applies and builds on x86_64 and PowerPC. Tobin C. Harding (3): staging: ks7010: invert conditional, reduce indentation staging: ks7010: rename identifier rc to ret staging: ks7010: fix checkpatch PARENTHESIS_ALIGNMENT drivers/staging/ks7010/ks7010_sdio.c | 41 ++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 21 deletions(-) -- 2.7.4 _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
