On Sun, 2017-02-26 at 21:23 +0530, Arushi Singhal wrote:
> Error was reported by checkpatch.pl as "Avoid multiple line
> dereference".And If there is boolean operator then it is
> fixed by Splitting line at boolean operator to satisfy coding
> style.
[]
> diff --git a/drivers/staging/xgifb/XGI_main_26.c
> b/drivers/staging/xgifb/XGI_main_26.c
[]
> @@ -878,30 +878,18 @@ static void XGIfb_post_setmode(struct xgifb_video_info
> *xgifb_info)
>
[]
> xgifb_reg_set(
> - XGIPART2,
> - 0x37,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][2]));
> + XGIPART2, 0x35, f[0]);
> + xgifb_reg_set(
> + XGIPART2, 0x36, f[1]);
> + xgifb_reg_set(
> + XGIPART2, 0x37, f[2]);
0 1 2 3 4 5 6 7 8
12345678901234567890123456789012345678901234567890123456789012345678901234567890
xgifb_reg_set(XGIPART2, 0x37, f[2]);
All of these fit nicely on a single line and you should
submit patches that make the most sense and do not need
revision when reformatting.
Please reformat all instances as above and resubmit.
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
