On Wed, Feb 01, 2017 at 05:39:01PM -0500, David Kershner wrote:
> From: David Binder <david.bin...@unisys.com>
> 
> Clarifies why the pointers returned from visorbus_get_device_by_id() in
> visorbus are validated. The check is performed in order to be extra
> careful, for the sake of added security, that the s-Par backend is
> providing us with a valid bus.
> 
> Signed-off-by: David Binder <david.bin...@unisys.com>
> Reported-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Signed-off-by: David Kershner <david.kersh...@unisys.com>
> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 1 +
>  drivers/staging/unisys/visorbus/visorchipset.c  | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c 
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index aea1aa2..4a11c89 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -800,6 +800,7 @@ fix_vbus_dev_info(struct visor_device *visordev)
>               return;
>  
>       bdev = visorbus_get_device_by_id(bus_no, BUS_ROOT_DEVICE, NULL);
> +     /* Validate that s-Par backend gave a good bus */

Same as the other reviews...

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to