On Wed, Jan 25, 2017 at 02:24:22PM +0200, Dragos Tarcatu wrote:
> Fixed the following checkpatch.pl errors in fb_pcd8544.c:
> 
> ERROR: Use 4 digit octal (0777) not decimal permissions
> +module_param(tc, uint, 0);
> ERROR: Use 4 digit octal (0777) not decimal permissions
> +module_param(bs, uint, 0);
> 
> Also made the two module parameters readable from sysfs.

Why?

That's a change in functionality, and should always be done in a
separate patch.  Along with a bunch of justification for it...

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to