The member localport and remoteport are unsigned. So fix the format
string accordingly.

The issue has been found by Cppcheck.

Signed-off-by: Stefam Wahren <stefan.wah...@i2se.com>
---
 .../vc04_services/interface/vchiq_arm/vchiq_core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 2e0e8ef..2139c94 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -3687,7 +3687,7 @@ static const char *msg_type_str(unsigned int msg_type)
        char buf[80];
        int len;
 
-       len = snprintf(buf, sizeof(buf), "Service %d: %s (ref %u)",
+       len = snprintf(buf, sizeof(buf), "Service %u: %s (ref %u)",
                service->localport, srvstate_names[service->srvstate],
                service->ref_count - 1); /*Don't include the lock just taken*/
 
@@ -3699,7 +3699,7 @@ static const char *msg_type_str(unsigned int msg_type)
                int tx_pending, rx_pending;
                if (service->remoteport != VCHIQ_PORT_FREE) {
                        int len2 = snprintf(remoteport, sizeof(remoteport),
-                               "%d", service->remoteport);
+                               "%u", service->remoteport);
                        if (service->public_fourcc != VCHIQ_FOURCC_INVALID)
                                snprintf(remoteport + len2,
                                        sizeof(remoteport) - len2,
-- 
1.7.9.5

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to