On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote:
> Fixed following checkpatch warning
> Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal
> permissions '0444'
>
> Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
> b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 5d2b702..9c286c3 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2103,21 +2103,21 @@ static struct device_attribute attrs[] = {
> bcm2048_rds_pi_match_write),
> __ATTR(rds_wline, 0644, bcm2048_rds_wline_read,
> bcm2048_rds_wline_write),
> - __ATTR(rds_pi, S_IRUGO, bcm2048_rds_pi_read, NULL),
> - __ATTR(rds_rt, S_IRUGO, bcm2048_rds_rt_read, NULL),
> - __ATTR(rds_ps, S_IRUGO, bcm2048_rds_ps_read, NULL),
> - __ATTR(fm_rds_flags, S_IRUGO, bcm2048_fm_rds_flags_read, NULL),
> - __ATTR(region_bottom_frequency, S_IRUGO,
> + __ATTR(rds_pi, 0444, bcm2048_rds_pi_read, NULL),
> + __ATTR(rds_rt, 0444, bcm2048_rds_rt_read, NULL),
> + __ATTR(rds_ps, 0444, bcm2048_rds_ps_read, NULL),
> + __ATTR(fm_rds_flags, 0444, bcm2048_fm_rds_flags_read, NULL),
> + __ATTR(region_bottom_frequency, 0444,
> bcm2048_region_bottom_frequency_read, NULL),
Why not use __ATTR_RO() for all of these instead?
thanks,
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
