From: Andrey Shvetsov <andrey.shvet...@k2l.de>

This patch moves initialization of the variables to the declaration
where possible.

Signed-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de>
Signed-off-by: Christian Gromm <christian.gr...@microchip.com>
---
 drivers/staging/most/hdm-usb/hdm_usb.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c 
b/drivers/staging/most/hdm-usb/hdm_usb.c
index 744c8d5..990a03e 100644
--- a/drivers/staging/most/hdm-usb/hdm_usb.c
+++ b/drivers/staging/most/hdm-usb/hdm_usb.c
@@ -326,10 +326,10 @@ static int hdm_poison_channel(struct most_interface 
*iface, int channel)
 static int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo)
 {
        struct most_channel_config *conf = &mdev->conf[channel];
-       unsigned int j, num_frames, frame_size;
+       unsigned int frame_size = get_stream_frame_size(conf);
+       unsigned int j, num_frames;
        u16 rd_addr, wr_addr;
 
-       frame_size = get_stream_frame_size(conf);
        if (!frame_size)
                return -EIO;
        num_frames = mbo->buffer_length / frame_size;
@@ -363,10 +363,10 @@ static int hdm_add_padding(struct most_dev *mdev, int 
channel, struct mbo *mbo)
 static int hdm_remove_padding(struct most_dev *mdev, int channel,
                              struct mbo *mbo)
 {
-       unsigned int j, num_frames, frame_size;
        struct most_channel_config *const conf = &mdev->conf[channel];
+       unsigned int frame_size = get_stream_frame_size(conf);
+       unsigned int j, num_frames;
 
-       frame_size = get_stream_frame_size(conf);
        if (!frame_size)
                return -EIO;
        num_frames = mbo->processed_length / USB_MTU;
@@ -1098,9 +1098,8 @@ static ssize_t store_value(struct most_dci_obj *dci_obj,
 {
        u16 val;
        u16 reg_addr;
-       int err;
+       int err = kstrtou16(buf, 16, &val);
 
-       err = kstrtou16(buf, 16, &val);
        if (err)
                return err;
 
-- 
1.9.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to