On 08/06/16 19:26, H Hartley Sweeten wrote:
This driver still uses some of old broken code in hwdrv_apci1564.c for the timer and counter subdevices. This code does not follow the comedi API and does not work without additional patches to the core.Tidy up the change-of-state support so that the dev->read_subdev can be used to handle the interrupt events from the timer and counter subdevices. Rewrite the timer and counter subdevice support so that it follows the comedi API. NOTE: The datasheet I have from ADDI-DATA just describes the registers. It does not have any functional information on the operation of the timer or counter. The new code might not work _correctly_ but it at least makes the subdevices work with the comedi API so that additional testing can be done. v2: mask the change-of-state input status in patch 1/6 at the request of Ian Abbott H Hartley Sweeten (6): staging: comedi: addi_apci_1564: clarify change-of-state interrupt support staging: comedi: addi_apci_1564: use comedi_handle_event() for timer staging: comedi: addi_apci_1564: use comedi_handle_event() for counters staging: comedi: addi_apci_1564: rewrite the timer subdevice support staging: comedi: addi_apci_1564: rewrite the counter subdevice support staging: comedi: addi_apci_1564: remove unnecessary wdog register defines .../comedi/drivers/addi-data/hwdrv_apci1564.c | 187 ------------- drivers/staging/comedi/drivers/addi_apci_1564.c | 305 ++++++++++++++++++--- 2 files changed, 264 insertions(+), 228 deletions(-) delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
Thanks, Hartley! Reviewed-by: Ian Abbott <abbo...@mev.co.uk> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
