> On 20-Mar-2016, at 10:03 PM, Roger H Newell <newell.ro...@gmail.com> wrote: > > > On Mar 20, 2016 1:21 PM, "Parth Sane" <laerdevstud...@gmail.com> wrote: > > > > > > > On 20-Mar-2016, at 9:18 PM, Joe Perches <j...@perches.com> wrote: > > > > > > On Sun, 2016-03-20 at 14:33 +0000, Parth Sane wrote: > > >> Fixed multiple parenthesis alignment warnings. > > >> Signed-off-by: Parth Sane <laerdevstud...@gmail.com> > > > > > > Please always add a blank line after your changelog and > > > before your "Signed-off-by:" line > > > > > >> diff --git a/drivers/staging/rtl8712/hal_init.c > > >> b/drivers/staging/rtl8712/hal_init.c > > > [] > > >> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) > > >> 0x0000ffff); > > >> memcpy(ppayload, ptr, dump_imem_sz); > > >> r8712_write_mem(padapter, RTL8712_DMA_VOQ, > > >> - dump_imem_sz + TXDESC_SIZE, > > >> + dump_imem_sz + TXDESC_SIZE, > > >> (u8 *)ptx_desc); > > > > > > Please align all lines of multi-line statements. > > > > > > checkpatch is a stupid little script. > > > You have to make sure your own patches are sensible. > > > > > > There are several things you should read and > > > understand in the Documentation directory. > > > > > > Documentation/CodingStyle > > > Documentation/SubmittingPatches > > > Documentation/SubmitChecklist > > > > > > Fixing checkpatch messages is sometimes a decent > > > way to understand this process, but the patches > > > that can be generated fixing these messages tend > > > to have low overall value. > > > > > > After doing a few of these, please move on to > > > some part of the kernel that interests you and > > > submit new code or start to fix actual defects. > > > > > > Maybe if you are interested in wireless drivers, > > > buy a NIC that isn't supported by the mac80211 > > > drivers and adapt the existing staging driver for > > > that variant. > > > > > > Code, test, validate, submit, repeat... > > > > > Hi, > > I’m first trying my hands at easy stuff before I actually move on to more > > difficult stuff. I will surely look in that direction. Thanks for your > > valuable inputs. > > Regards, > > Parth Sane > > > > _______________________________________________ > > devel mailing list > > de...@linuxdriverproject.org > > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel > > > > www.kernelnewbies.org is an excellent resource for getting started. Check out > the first patch tutorial, it walks you through all the basics of creating and > sending a properly formated patch. You're better off learning to do it right > the first time, if its not right the patch simply won't be accepted and > you'll have to redo it anyway. Take some time to go through the tutorial I > mentioned. Good luck > > Roger H. Newell > Hi Roger, Thanks for your comments. I’ve correctly submitted a patchset for the multiple FSF notices, maybe you can comment if its any good?. I’m through the rough patch and now understand the process now quite fairly. I did checkout kernelnewbies.org before I submitted the patch, but alas I needed some practical XP. Regards, Parth Sane
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
