[PATCH 2/6] staging: unisys: visorbus: cleanup gotos in parser_init_byte_stream

[David Kershner]

Signed-off-by: David Kershner <david.kersh...@unisys.com>
Signed-off-by: Timothy Sell <timothy.s...@unisys.com>
---
 drivers/staging/unisys/visorbus/visorchipset.c | 39 ++++++++++----------------
 1 file changed, 15 insertions(+), 24 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c 
b/drivers/staging/unisys/visorbus/visorchipset.c
index 6ab659c..da73e9e 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -359,7 +359,6 @@ static struct parser_context *
 parser_init_byte_stream(u64 addr, u32 bytes, bool local, bool *retry)
 {
        int allocbytes = sizeof(struct parser_context) + bytes;
-       struct parser_context *rc = NULL;
        struct parser_context *ctx = NULL;
 
        if (retry)
@@ -374,15 +373,13 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, 
bool *retry)
            > MAX_CONTROLVM_PAYLOAD_BYTES) {
                if (retry)
                        *retry = true;
-               rc = NULL;
-               goto cleanup;
+               return NULL;
        }
        ctx = kzalloc(allocbytes, GFP_KERNEL | __GFP_NORETRY);
        if (!ctx) {
                if (retry)
                        *retry = true;
-               rc = NULL;
-               goto cleanup;
+               return NULL;
        }
 
        ctx->allocbytes = allocbytes;
@@ -393,35 +390,29 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, 
bool *retry)
        if (local) {
                void *p;
 
-               if (addr > virt_to_phys(high_memory - 1)) {
-                       rc = NULL;
-                       goto cleanup;
-               }
+               if (addr > virt_to_phys(high_memory - 1))
+                       goto err_finish_ctx;
+
                p = __va((unsigned long)(addr));
                memcpy(ctx->data, p, bytes);
        } else {
                void *mapping = memremap(addr, bytes, MEMREMAP_WB);
 
-               if (!mapping) {
-                       rc = NULL;
-                       goto cleanup;
-               }
+               if (!mapping)
+                       goto err_finish_ctx;
+
                memcpy(ctx->data, mapping, bytes);
                memunmap(mapping);
        }
 
        ctx->byte_stream = true;
-       rc = ctx;
-cleanup:
-       if (rc) {
-               controlvm_payload_bytes_buffered += ctx->param_bytes;
-       } else {
-               if (ctx) {
-                       parser_done(ctx);
-                       ctx = NULL;
-               }
-       }
-       return rc;
+       controlvm_payload_bytes_buffered += ctx->param_bytes;
+
+       return ctx;
+
+err_finish_ctx:
+       parser_done(ctx);
+       return NULL;
 }
 
 static uuid_le
-- 
1.9.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel