On Sun, Dec 13, 2015 at 12:54:27PM +0300, Bhaktipriya Shridhar wrote:
> This patch fixes checkpatch.pl check:
> CHECK: Comparison to NULL could be written "!rx_p"
> + if (*rx_p == NULL) {
>
Actually it should be "if (!*rx_p)". checkpatch.pl appears to have a
bug here.
regards,
dan carpenter
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
> ---
> drivers/staging/iio/accel/sca3000_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/accel/sca3000_ring.c
> b/drivers/staging/iio/accel/sca3000_ring.c
> index 20b878d..5339b10 100644
> --- a/drivers/staging/iio/accel/sca3000_ring.c
> +++ b/drivers/staging/iio/accel/sca3000_ring.c
> @@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
> }
> };
> *rx_p = kmalloc(len, GFP_KERNEL);
> - if (*rx_p == NULL) {
> + if (!rx_p) {
> ret = -ENOMEM;
> goto error_ret;
> }
> --
> 2.1.4
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
