[PATCH v2 1/2] staging: fwserial: Fix pointer comparison to NULL checkpatch problem

[Rajan Vaja]

Fix pointer comparison to NULL problem reported by checkpatch.

Signed-off-by: Rajan Vaja <rajan.v...@gmail.com>
---
 drivers/staging/fwserial/dma_fifo.c |   10 +++++-----
 drivers/staging/fwserial/fwserial.c |    4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/fwserial/dma_fifo.c 
b/drivers/staging/fwserial/dma_fifo.c
index 7a3347c..4cd3ed3 100644
--- a/drivers/staging/fwserial/dma_fifo.c
+++ b/drivers/staging/fwserial/dma_fifo.c
@@ -106,7 +106,7 @@ void dma_fifo_free(struct dma_fifo *fifo)
 {
        struct dma_pending *pending, *next;

-       if (fifo->data == NULL)
+       if (!fifo->data)
                return;

        list_for_each_entry_safe(pending, next, &fifo->pending, link)
@@ -123,7 +123,7 @@ void dma_fifo_reset(struct dma_fifo *fifo)
 {
        struct dma_pending *pending, *next;

-       if (fifo->data == NULL)
+       if (!fifo->data)
                return;

        list_for_each_entry_safe(pending, next, &fifo->pending, link)
@@ -149,7 +149,7 @@ int dma_fifo_in(struct dma_fifo *fifo, const void *src, int 
n)
 {
        int ofs, l;

-       if (fifo->data == NULL)
+       if (!fifo->data)
                return -ENOENT;
        if (fifo->corrupt)
                return -ENXIO;
@@ -192,7 +192,7 @@ int dma_fifo_out_pend(struct dma_fifo *fifo, struct 
dma_pending *pended)
 {
        unsigned len, n, ofs, l, limit;

-       if (fifo->data == NULL)
+       if (!fifo->data)
                return -ENOENT;
        if (fifo->corrupt)
                return -ENXIO;
@@ -252,7 +252,7 @@ int dma_fifo_out_complete(struct dma_fifo *fifo, struct 
dma_pending *complete)
 {
        struct dma_pending *pending, *next, *tmp;

-       if (fifo->data == NULL)
+       if (!fifo->data)
                return -ENOENT;
        if (fifo->corrupt)
                return -ENXIO;
diff --git a/drivers/staging/fwserial/fwserial.c 
b/drivers/staging/fwserial/fwserial.c
index b3ea4bb..38ba145 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1701,7 +1701,7 @@ static void fwserial_virt_plug_complete(struct fwtty_peer 
*peer,
        dma_fifo_change_tx_limit(&port->tx_fifo, port->max_payload);
        spin_unlock_bh(&peer->port->lock);

-       if (port->port.console && port->fwcon_ops->notify != NULL)
+       if (port->port.console && port->fwcon_ops->notify)
                (*port->fwcon_ops->notify)(FWCON_NOTIFY_ATTACH, port->con_data);

        fwtty_info(&peer->unit, "peer (guid:%016llx) connected on %s\n",
@@ -1808,7 +1808,7 @@ static void fwserial_release_port(struct fwtty_port 
*port, bool reset)
        RCU_INIT_POINTER(port->peer, NULL);
        spin_unlock_bh(&port->lock);

-       if (port->port.console && port->fwcon_ops->notify != NULL)
+       if (port->port.console && port->fwcon_ops->notify)
                (*port->fwcon_ops->notify)(FWCON_NOTIFY_DETACH, port->con_data);
 }

--
1.7.9.5

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel