> -----Original Message-----
> From: Jiang Liu [mailto:jiang....@linux.intel.com]
> Sent: Thursday, October 29, 2015 6:55 PM
> To: Jake Oshins <ja...@microsoft.com>; gre...@linuxfoundation.org; KY
> Srinivasan <k...@microsoft.com>; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...@redhat.com; t...@redhat.com; Haiyang Zhang
> <haiya...@microsoft.com>; marc.zyng...@arm.com;
> bhelg...@google.com; linux-...@vger.kernel.org
> Subject: Re: [PATCH v4 4/7] PCI: Add fwnode_handle to pci_sysdata
>
> >
> > +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> > +static inline void *pci_fwnode(struct pci_bus *bus)
> > +{
> > + struct pci_sysdata *sd = bus->sysdata;
> > + return sd->fwnode;
> > +}
> > +#endif
> Hi Jakeo,
> I would be better that if the function name indicates
> that we are getting PCI host bridge(root bus) firmware node.
> And you also need some magic here to avoid breaking compilation
> on other archs:
> in arch/x86/include/asm/pci.h
> #define pci_fwnode pci_fwnode
>
> in include/asm-generic/pci.h
> #ifndef pci_fwnode
> #define pci_fwnode(bus) ((void)(bus),NULL)
> #endif
>
> Thanks,
> Gerry
Got it. Thanks. I'll fix and resend.
-- Jake Oshins
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
