> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Thursday, August 20, 2015 2:35 AM
> To: Rivera Jose-B46482
> Cc: gre...@linuxfoundation.org; a...@arndb.de;
> de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; Yoder Stuart-
> B08248; katz Itai-RM05202; Wood Scott-B07421; ag...@suse.de; Hamciuc
> Bogdan-BHAMCIU1; Marginean Alexandru-R89243; Sharma Bhupesh-B45370; Erez
> Nir-RM30794; Schmitt Richard-B43082
> Subject: Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus
> driver
> 
> On Wed, Aug 19, 2015 at 11:52:40AM -0500, J. German Rivera wrote:
> > Since signatures of flib functions have changed, we had to change all
> > the corresponding calls in the MC bus driver
> >
> 
> What does upgrade mean here?  I feel like this is the kind of patch we
> reject without reading the patch because the description is too vague and
> you can tell from the diff stats that it is going to be too huge to
> review.
We will do some refactoring to make this easier to review.

Thanks,

german
> 
> I looked at the first few lines and we are making a ball of changes.
> Copyright notices, adding function parameters, renaming functions.  This
> needs to be explained a lot better and probably split into multiple
> patches.
> 
> Btw, the trees are closed for the next 3-4 weeks until after 4.3-rc2 is
> released.
> 
> regards,
> dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to