On Sat, Aug 01, 2015 at 01:04:48PM +0200, Christian Gromm wrote:
> On Fri, 31 Jul 2015 17:14:32 +0530
> Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote:
>
> > On Thu, Jul 30, 2015 at 06:19:41PM +0200, Christian Gromm wrote:
> > > This patch replaces pr_*() functions with dev_*().
> > >
> > > Reported-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> > > Signed-off-by: Christian Gromm <christian.gr...@microchip.com>
> > > ---
> > <snip>
> > > + dev_notice(dev,
> > > + "Channel %d - rouding buffer size to %d bytes, "
> > > + "channel config says %d bytes\n",
> > user visible strings should not be splitted.
>
> This is a dilemma. Either cracking the 80 character boarder or splitting the
> string.
> Not sure what's worse.
checkpatch should not give you warning for uservisible strings of more
than 80 char. CodingStyle says "However, never break user-visible
strings such as printk messages, because that breaks the ability to grep
for them."
regards
sudip
>
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
