On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote: > Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY > checkpatch.pl warning. > It will prevent accidential "Fix" to ether_addr_copy(). > > Signed-off-by: Mateusz Kulikowski <mateusz.kulikow...@gmail.com> > --- > drivers/staging/rtl8192e/rtllib_rx.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtllib_rx.c > b/drivers/staging/rtl8192e/rtllib_rx.c > index ebb328d..65e4d13 100644 > --- a/drivers/staging/rtl8192e/rtllib_rx.c > +++ b/drivers/staging/rtl8192e/rtllib_rx.c > @@ -488,15 +488,19 @@ void rtllib_indicate_packets(struct rtllib_device > *ieee, struct rtllib_rxb **prx > * and replace EtherType > */ > skb_pull(sub_skb, SNAP_SIZE); > - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, > ETH_ALEN); > - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, > ETH_ALEN); > + memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, > + ETH_ALEN); /* Must be unaligned */
Which part isn't aligned? I think they both are. regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
