On Thu, Apr 02, 2015 at 07:35:45PM +0200, Guillaume Matheron wrote:
> I focused on function declarations (placed return type on the same line
> as function name), and spaces between function name and parenthesis
>
> Signed-off-by: Guillaume Matheron <guillaume.mathe...@ens.fr>
> ---
> .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 445
> +++++++++------------
> 1 file changed, 186 insertions(+), 259 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> index 6510169..ae4069e 100644
> --- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> +++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> @@ -53,8 +53,7 @@ static lnd_t the_o2iblnd = {
>
> kib_data_t kiblnd_data;
>
> -static __u32
> -kiblnd_cksum(void *ptr, int nob)
> +static __u32 kiblnd_cksum(void *ptr, int nob)
I prefer the way you do it, but we allow either in the kernel. So just
leave these as-is if it's done consistently within the file.
> kib_rdma_desc_t *rd;
> int nob;
> int n;
> int i;
>
> - LASSERT (msg->ibm_type == IBLND_MSG_GET_REQ ||
> + LASSERT(msg->ibm_type == IBLND_MSG_GET_REQ ||
> msg->ibm_type == IBLND_MSG_PUT_ACK);
Change the next line as well so the alignment is correct. Anyway, this
patch needs does two things instead of just one thing at a time.
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
