On Sat, Mar 14, 2015 at 12:20:36AM +0100, Isaac Lleida wrote:
> This path implements a bit array representing the LCD signal states instead 
> of the old "struct bits", which used char to represent a single bit. This 
> will reduce the memory usage.

commit log should wrap at 72 char

> 
> Signed-off-by: Isaac Lleida <ille...@openaliasbox.org

missing '>'

> ---
> v2: fix some stupid errors from the first patch
> 
<snip>
> +#define BIT_ON(b, m) (b |= m)
> +#define BIT_OFF(b, m)        (b &= ~m)
> +#define BIT_CHK(b, m)        (b & m)
> +#define BIT_MOD(b, m, v)                             \
> +     (((v) ? BIT_ON(b, m) : BIT_OFF(b, m))?1:0)      \
missing ' ' around ? and :

please test your patch by checkpatch.pl before sending

regards
sudip
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to