On Thu, 2015-02-19 at 21:54 -0800, Tolga Ceylan wrote:
> Resolved space required after that ',' errors reported by checkpatch.

trivia:

> diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c 
> b/drivers/staging/rtl8192u/r819xU_firmware.c
[]
> @@ -66,7 +66,7 @@ static bool fw_download_code(struct net_device *dev, u8 
> *code_virtual_address,
>               skb  = dev_alloc_skb(USB_HWDESC_HEADER_LEN + frag_length + 4);
>               if (!skb)
>                       return false;
> -             memcpy((unsigned char *)(skb->cb),&dev,sizeof(dev));
> +             memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));


Might as well remove the unnecessary cast too:

                memcpy(skb->cb, &dev, sizeof(dev));

but it might be better to avoid the memcpy and use an assign

        *(struct net_device *)skb->cb = dev;

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to