On Tue, 2015-02-03 at 19:58 +0100, Bilel DRIRA wrote:
> This patch fix the checkpatch.pl WARNING:
[]
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c 
> b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
[]
> @@ -1963,11 +1948,10 @@ static irqreturn_t ft1000_interrupt(int irq, void 
> *dev_id)
>                                               ft1000_read_reg(dev,
>                                                               
> FT1000_REG_MAG_DFSR);
>                               }
> -                             if (tempword & 0x1f) {
> +                             if (tempword & 0x1f)
>                                       ft1000_copy_up_pkt(dev);
> -                             } else {
> +                             else
>                                       break;
> -                             }
>                               cnt++;
>                       } while (cnt < MAX_RCV_LOOP);
>  

trivia: the logic here is generally better inverted:

                                if (!(tempword & 0x1f))
                                        break;
                                ft1000_copy_up_pkt(dev);
                                cnt++;
                        } while (cnt < etc...)


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to