Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c |   13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c 
b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 552d943..e3656f0 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -108,7 +108,6 @@ void rtl8192e_SetHwReg(struct net_device *dev, u8 variable, 
u8 *val)
        case HW_VAR_MEDIA_STATUS:
        {
                enum rt_op_mode OpMode = *((enum rt_op_mode *)(val));
-               enum led_ctl_mode LedAction = LED_CTL_NO_LINK;
                u8              btMsr = read_nic_byte(dev, MSR);
 
                btMsr &= 0xfc;
@@ -116,7 +115,6 @@ void rtl8192e_SetHwReg(struct net_device *dev, u8 variable, 
u8 *val)
                switch (OpMode) {
                case RT_OP_MODE_INFRASTRUCTURE:
                        btMsr |= MSR_INFRA;
-                       LedAction = LED_CTL_LINK;
                        break;
 
                case RT_OP_MODE_IBSS:
@@ -125,7 +123,6 @@ void rtl8192e_SetHwReg(struct net_device *dev, u8 variable, 
u8 *val)
 
                case RT_OP_MODE_AP:
                        btMsr |= MSR_AP;
-                       LedAction = LED_CTL_LINK;
                        break;
 
                default:
@@ -1695,11 +1692,10 @@ static void rtl8192_process_phyinfo(struct r8192_priv 
*priv, u8 *buffer,
        static u32 last_beacon_adc_pwdb;
        struct rtllib_hdr_3addr *hdr;
        u16 sc;
-       unsigned int frag, seq;
+       unsigned int seq;
 
        hdr = (struct rtllib_hdr_3addr *)buffer;
        sc = le16_to_cpu(hdr->seq_ctl);
-       frag = WLAN_GET_SEQ_FRAG(sc);
        seq = WLAN_GET_SEQ_SEQ(sc);
        curr_st->Seq_Num = seq;
        if (!prev_st->bIsAMPDU)
@@ -2335,13 +2331,8 @@ bool rtl8192_HalRxCheckStuck(struct net_device *dev)
                for (i = 0; i < SilentResetRxSoltNum; i++)
                        TotalRxStuckCount += priv->SilentResetRxStuckEvent[i];
 
-               if (TotalRxStuckCount == SilentResetRxSoltNum) {
+               if (TotalRxStuckCount == SilentResetRxSoltNum)
                        bStuck = true;
-                       for (i = 0; i < SilentResetRxSoltNum; i++)
-                               TotalRxStuckCount +=
-                                        priv->SilentResetRxStuckEvent[i];
-               }
-
 
        } else {
                priv->SilentResetRxStuckEvent[SlotIndex] = 0;
-- 
1.7.10.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to