Even though it should never happen, handle the case that the clock
notifier is called with an unexpected clock handle. This avoids the
compiler warning:
   drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c: In function 
'clk_wzrd_clk_notifier':
>> drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c:99:6: warning: 'max' 
>> may be used uninitialized in this function [-Wmaybe-uninitialized]
      if (ndata->new_rate > max)
         ^

Reported-by: kbuild test robot <fengguang...@intel.com>
Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com>
---
 drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c 
b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
index 471d0877f382..048247fa9e34 100644
--- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
+++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
@@ -91,8 +91,10 @@ static int clk_wzrd_clk_notifier(struct notifier_block *nb, 
unsigned long event,
 
        if (ndata->clk == clk_wzrd->clk_in1)
                max = clk_wzrd_max_freq[clk_wzrd->speed_grade - 1];
-       if (ndata->clk == clk_wzrd->axi_clk)
+       else if (ndata->clk == clk_wzrd->axi_clk)
                max = WZRD_ACLK_MAX_FREQ;
+       else
+               return NOTIFY_DONE;     /* should never happen */
 
        switch (event) {
        case PRE_RATE_CHANGE:
-- 
2.2.1.1.gb42cc81

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to