Checkpatch was complaining about the else statement because the if statement
had a return '1' call. Taking a look at the function which this else statement
belongs, you can see that it has an switch case statement.
The main idea of the function is to return '1' if you get into any of the cases
(including the default case where the "problematic" if/else statement is
declared).
If any of the cases is not sufficient the function should return '0', so the
else statement that checkpath was complaining could be removed, and what was
done inside this else statement can be done outside the switch case statement
and then we return '0'.
This way we have a cleaner code and no checkpatch error complaints.
Signed-off-by: Eduardo Barretto <edusbarre...@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 55d2f56..de33a07 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -4123,12 +4123,11 @@ static int hfa384x_isgood_pdrcode(u16 pdrcode)
pr_debug("Encountered unknown PDR#=0x%04x, assuming
it's ok.\n",
pdrcode);
return 1;
- } else {
- /* bad code */
- pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000),
assuming it's bad.\n",
- pdrcode);
- return 0;
}
+ break;
}
- return 0; /* avoid compiler warnings */
+ /* bad code */
+ pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's
bad.\n",
+ pdrcode);
+ return 0;
}
--
2.2.0
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
