Hi
Ok, if you want, otherwise we can put it after the NULL check?
Kind regards
Rickard Strandqvist
2014-12-14 23:52 GMT+01:00 Joe Perches <j...@perches.com>:
> On Sun, 2014-12-14 at 23:42 +0100, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null pointer dereference.
>> Was largely found by using a static code analysis program called cppcheck.
> []
>> diff --git a/drivers/staging/vt6655/wmgr.c b/drivers/staging/vt6655/wmgr.c
> []
>> @@ -4391,7 +4391,7 @@ bAdd_PMKID_Candidate(
>> unsigned int ii = 0;
>>
>> pr_debug("bAdd_PMKID_Candidate START: (%d)\n",
>> - (int)pDevice->gsPMKIDCandidate.NumCandidates);
>> + (int)(pDevice ? pDevice->gsPMKIDCandidate.NumCandidates : 0));
>
> This is a function tracing printk.
> I think it's better to just remove it.
>
>
>
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
