On Sat, 2014-11-08 at 22:14 +0100, Krzysztof Konopko wrote:
> scripts/checkpatch.pl reports a coding style problem in xmit_linux.c
[]
> diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c 
> b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
[]
> @@ -67,9 +67,8 @@ uint _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, 
> uint rlen)
>  int rtw_endofpktfile(struct pkt_file *pfile)
>  {
>  
> -     if (pfile->pkt_len == 0) {
> +     if (pfile->pkt_len == 0)
>               return true;
> -     }
>  
> 
>       return false;

This should probably be

bool rtw_endofpktfile(const struct pkt_file *pfile_
{
        return !pfile->pkt_len;
}

or just removed altogether and tested directly
in the one place it's used.


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to