On Mon, 2014-08-04 at 22:47 -0300, Murilo Opsfelder Araujo wrote: > This patch adds missing blank line between declarations and code, and > adjust code to fit 80-chars limit. [] > diff --git a/drivers/staging/iio/accel/sca3000_core.c > b/drivers/staging/iio/accel/sca3000_core.c [] > @@ -506,7 +506,8 @@ static int sca3000_read_raw(struct iio_dev *indio_dev, > mutex_unlock(&st->lock); > return ret; > } > - *val = ((st->rx[0] & 0x3F) << 3) | ((st->rx[1] & 0xE0) > >> 5); > + *val = ((st->rx[0] & 0x3F) << 3) > + | ((st->rx[1] & 0xE0) >> 5);
Please don't strain to fit 80 columns. If this is done, please strive to make it quickly intelligible for humans. I think this would be better as: + *val = ((st->rx[0] & 0x3F) << 3) | + ((st->rx[1] & 0xE0) >> 5); so that the mask and shift are aligned. _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
