On Wed, Jun 18, 2014 at 05:26:18PM -0400, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause <xerofo...@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 ++++
> 1 file changed, 4 insertions(+)
Some more meta-comments. Your subject: should give people a clue as to
where in the kernel you are changing. This patch would be:
Subject: staging: rtl8192e: check return value of dev_skb_alloc
And then in the body of the patch changelog area, explain why you are
doing this.
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 1a95d1f..1a90546 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> @@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8
> *code_virtual_address,
> }
>
> skb = dev_alloc_skb(frag_length + 4);
> + if (!skb) {
> + rt_status = false;
> + return rt_status;
> + }
Does that really look like the correct thing to be doing here? Surely
you can delete 2 lines of this patch, right?
thanks,
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
