From: Jérôme Pouiller <jerome.pouil...@silabs.com>

If PDS data is not correct, the device is unlikely to work. Worse, the
pinmux maybe it misconfigured and it can generate IRQ-storms. Therefore,
do not try to start-up the device if PDS is invalid.

Signed-off-by: Jérôme Pouiller <jerome.pouil...@silabs.com>
---
 drivers/staging/wfx/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
index 4386e9957ee6..b24ff4b31b72 100644
--- a/drivers/staging/wfx/main.c
+++ b/drivers/staging/wfx/main.c
@@ -409,7 +409,9 @@ int wfx_probe(struct wfx_dev *wdev)
 
        dev_dbg(wdev->dev, "sending configuration file %s\n",
                wdev->pdata.file_pds);
-       wfx_send_pdata_pds(wdev);
+       err = wfx_send_pdata_pds(wdev);
+       if (err)
+               goto err0;
 
        wdev->poll_irq = false;
        err = wdev->hwbus_ops->irq_subscribe(wdev->hwbus_priv);
-- 
2.33.0

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to