On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote: > Remove prohibited space and fix line over 80 characters of > memset(...) to meet kernel coding style. [] > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c > b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c [] > @@ -113,7 +113,7 @@ ksocknal_create_peer(ksock_peer_t **peerp, lnet_ni_t *ni, > lnet_process_id_t id) > if (peer == NULL) > return -ENOMEM; > > - memset (peer, 0, sizeof (*peer)); /* NULL pointers/clear flags > etc */ > + memset(peer, 0, sizeof(*peer)); /* NULL pointers/clear flags etc */
It looks like this memset is unnecessary as it's already zeroed by LIBCFS_ALLOC-> LIBCFS_ALLOC_GFP->LIBCFS_ALLOC_POST->memset. It seems as if all these ALLOC macros could use quite a bit of cleaning/sorting out. _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
