Hi Emmanouil, Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing] [also build test ERROR on v5.10-rc4 next-20201116] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Emmanouil-Perselis/Fix-warning-for-static-const-char-array-in-audio_manager_module-c/20201117-044852 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 0d79a48440f559ac939d1be2089757c5e4ab16c7 config: x86_64-randconfig-a006-20201115 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ace9653c11c6308401dcda2e8b26bf97e6e66e30) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/69022592162daaee87b29588cd562da4439f0517 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Emmanouil-Perselis/Fix-warning-for-static-const-char-array-in-audio_manager_module-c/20201117-044852 git checkout 69022592162daaee87b29588cd562da4439f0517 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): >> drivers/staging/greybus/audio_manager_module.c:162:3: error: initializer >> element is not a compile-time constant name_string, ^~~~~~~~~~~ >> drivers/staging/greybus/audio_manager_module.c:180:46: error: passing 'const >> char *const [7]' to parameter of type 'char **' discards qualifiers in >> nested pointer types >> [-Werror,-Wincompatible-pointer-types-discards-qualifiers] kobject_uevent_env(&module->kobj, KOBJ_ADD, envp); ^~~~ include/linux/kobject.h:241:10: note: passing argument to parameter 'envp' here char *envp[]); ^ 2 errors generated. vim +162 drivers/staging/greybus/audio_manager_module.c 8db00736d365b7 Svetlin Ankov 2016-01-13 151 8db00736d365b7 Svetlin Ankov 2016-01-13 152 static void send_add_uevent(struct gb_audio_manager_module *module) 8db00736d365b7 Svetlin Ankov 2016-01-13 153 { 8db00736d365b7 Svetlin Ankov 2016-01-13 154 char name_string[128]; 8db00736d365b7 Svetlin Ankov 2016-01-13 155 char vid_string[64]; 8db00736d365b7 Svetlin Ankov 2016-01-13 156 char pid_string[64]; d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16 157 char intf_id_string[64]; a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 158 char ip_devices_string[64]; a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 159 char op_devices_string[64]; 8db00736d365b7 Svetlin Ankov 2016-01-13 160 69022592162daa Emmanouil Perselis 2020-11-16 161 static const char * const envp[] = { 8db00736d365b7 Svetlin Ankov 2016-01-13 @162 name_string, 8db00736d365b7 Svetlin Ankov 2016-01-13 163 vid_string, 8db00736d365b7 Svetlin Ankov 2016-01-13 164 pid_string, d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16 165 intf_id_string, a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 166 ip_devices_string, a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 167 op_devices_string, 8db00736d365b7 Svetlin Ankov 2016-01-13 168 NULL 8db00736d365b7 Svetlin Ankov 2016-01-13 169 }; 8db00736d365b7 Svetlin Ankov 2016-01-13 170 8db00736d365b7 Svetlin Ankov 2016-01-13 171 snprintf(name_string, 128, "NAME=%s", module->desc.name); 8db00736d365b7 Svetlin Ankov 2016-01-13 172 snprintf(vid_string, 64, "VID=%d", module->desc.vid); 8db00736d365b7 Svetlin Ankov 2016-01-13 173 snprintf(pid_string, 64, "PID=%d", module->desc.pid); d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16 174 snprintf(intf_id_string, 64, "INTF_ID=%d", module->desc.intf_id); a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 175 snprintf(ip_devices_string, 64, "I/P DEVICES=0x%X", a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 176 module->desc.ip_devices); a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 177 snprintf(op_devices_string, 64, "O/P DEVICES=0x%X", a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 178 module->desc.op_devices); 8db00736d365b7 Svetlin Ankov 2016-01-13 179 8db00736d365b7 Svetlin Ankov 2016-01-13 @180 kobject_uevent_env(&module->kobj, KOBJ_ADD, envp); 8db00736d365b7 Svetlin Ankov 2016-01-13 181 } 8db00736d365b7 Svetlin Ankov 2016-01-13 182 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
