fix following warning by dynamically allocating memory:
dgnc_tty.c:583:1: warning: the frame size of 1060 bytes is larger than 1024 
bytes [-Wframe-larger-than=]

Signed-off-by: Martin Kepplinger <mart...@posteo.de>
---
This is more of a question. Is this a desired solution to fixing such a
frame size warning?

thanks,
                martin

 drivers/staging/dgnc/dgnc_tty.c |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f0b17c3..1c78cc2 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -481,8 +481,8 @@ void dgnc_sniff_nowait_nolock(struct channel_t *ch, uchar 
*text, uchar *buf, int
        int nbuf;
        int i;
        int tmpbuflen;
-       char tmpbuf[TMPBUFLEN];
-       char *p = tmpbuf;
+       char *tmpbuf;
+       char *p;
        int too_much_data;
 
        /* Leave if sniff not open */
@@ -492,6 +492,13 @@ void dgnc_sniff_nowait_nolock(struct channel_t *ch, uchar 
*text, uchar *buf, int
        do_gettimeofday(&tv);
 
        /* Create our header for data dump */
+       tmpbuf = kmalloc(TMPBUFLEN, GFP_KERNEL);
+       if (!tmpbuf) {
+               pr_err("dgnc: memory allocation error\n");
+               return;
+       }
+       p = tmpbuf;
+
        p += sprintf(p, "<%ld %ld><%s><", tv.tv_sec, tv.tv_usec, text);
        tmpbuflen = p - tmpbuf;
 
-- 
1.7.10.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to