On Tue, Mar 18, 2014 at 10:25:27AM -0400, Wang, Xiaoming wrote:
> pcmd->parmbuf->pbuf has been allocated if command is 
> GEN_CMD_CODE(_Set_Drv_Extra),
> and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by 
> rtw_dequeue_cmd.
> The memory leak happened on this branch "if( _FAIL == 
> rtw_cmd_filter(pcmdpriv, pcmd) )"
> which goto post_process directly against freeing pcmd->parmbuf->pbuf in
> rtw_drvextra_cmd_hdl which is the cmd_hdl if command is (_Set_Drv_Extra).
> This patch free pcmd->parmbuf->pbuf on the forgotten branch to avoid memory 
> leak.
> 
> Signed-off-by: Zhang Dongxing <dongxing.zh...@intel.com>
> Signed-off-by: xiaoming wang <xiaoming.w...@intel.com>

You obviously didn't test this as it breaks the build :(

{sigh}

Please retry after 3.15-rc1 is out.
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to