On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote:
> @@ -1174,7 +1179,8 @@ cleanup_hdlc(void)
>                       ci = (ci_t *)(netdev_priv(hi->ndev));
>                       for (j = 0; j < ci->max_port; j++)
>                               for (k = 0; k < MUSYCC_NCHANS; k++)
> -                                     if ((ndev = ci->port[j].chan[k]->user))
> +                                     ndev = ci->port[j].chan[k]->user;
> +                                     if (ndev)
>                                       {
>                                               do_deluser(ndev, 0);
>                                       }


This patch introduces a bug here because the inner for loop now has two
statement but no curly braces.

regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to