On 2/10/14, Kirill Tkhai <tk...@yandex.ru> wrote: > Do not call kfree() till timer function is finished. > > [This was found using grep. Compiled tested only] > > Signed-off-by: Kirill Tkhai <tk...@yandex.ru> > CC: Joe Perches <j...@perches.com> > CC: Greg Kroah-Hartman <gre...@linuxfoundation.org>
CC Chris Harrer. The problem with that driver is that alacritech guys don't seem to care. Not sure if anyone has a hardware to test the driver and probably the code is completely broken. Probably the better option is to drop the code from the staging tree... > --- > drivers/staging/slicoss/slicoss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/drivers/staging/slicoss/slicoss.c > b/drivers/staging/slicoss/slicoss.c > index 1426ca4..e0de497 100644 > --- a/drivers/staging/slicoss/slicoss.c > +++ b/drivers/staging/slicoss/slicoss.c > @@ -2970,7 +2970,7 @@ static void slic_card_cleanup(struct sliccard *card) > { > if (card->loadtimerset) { > card->loadtimerset = 0; > - del_timer(&card->loadtimer); > + del_timer_sync(&card->loadtimer); > } > > slic_debug_card_destroy(card); > _______________________________________________ > devel mailing list > de...@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel > -- Regards, Denis _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel