> -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Monday, February 10, 2014 8:29 AM > To: Haiyang Zhang; da...@davemloft.net; net...@vger.kernel.org > Cc: KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux- > ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org > Subject: Re: [PATCH net] hyperv: Fix the carrier status setting > > Hello. > > On 10-02-2014 5:07, Haiyang Zhang wrote: > > > Signed-off-by: Haiyang Zhang <haiya...@microsoft.com> > > Reviewed-by: K. Y. Srinivasan <k...@microsoft.com> > > --- > > drivers/net/hyperv/netvsc_drv.c | 24 +++++++++++++++--------- > > 1 files changed, 15 insertions(+), 9 deletions(-) > > > diff --git a/drivers/net/hyperv/netvsc_drv.c > > b/drivers/net/hyperv/netvsc_drv.c index 7756118..836211c 100644 > > --- a/drivers/net/hyperv/netvsc_drv.c > > +++ b/drivers/net/hyperv/netvsc_drv.c > [...] > > @@ -229,15 +238,17 @@ void netvsc_linkstatus_callback(struct hv_device > *device_obj, > > struct net_device *net; > > struct net_device_context *ndev_ctx; > > struct netvsc_device *net_device; > > + struct rndis_device *rdev; > > > > net_device = hv_get_drvdata(device_obj); > > + rdev = net_device->extension; > > + > > + rdev->link_state = !(status == 1); > > Why not just 'status != 1'?
I will simplify it. Thanks, - Haiyang _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
