On Thu, Jan 30, 2014 at 07:14:02PM +0530, Avinash kumar wrote:
> drivers:staging:dgnc:dpacompat.h- removed following checkpatch.pl reported 
> warnings
> 
> sccc@ubuntu:~/lk/rc/linux$ ./scripts/checkpatch.pl --terse --file 
> drivers/staging/dgnc/dpacompat.h 
> drivers/staging/dgnc/dpacompat.h:109: ERROR: Macros with complex values 
> should be enclosed in parenthesis
> drivers/staging/dgnc/dpacompat.h:110: ERROR: Macros with complex values 
> should be enclosed in parenthesis
> drivers/staging/dgnc/dpacompat.h:111: ERROR: Macros with complex values 
> should be enclosed in parenthesis
> drivers/staging/dgnc/dpacompat.h:114: WARNING: line over 80 characters
> drivers/staging/dgnc/dpacompat.h:114: ERROR: Macros with complex values 
> should be enclosed in parenthesis
> drivers/staging/dgnc/dpacompat.h:115: WARNING: line over 80 characters
> drivers/staging/dgnc/dpacompat.h:115: ERROR: Macros with complex values 
> should be enclosed in parenthesis
> total: 5 errors, 2 warnings, 115 lines checked
> 
> Signed-off-by: Avinash Kumar <avi.kp....@gmail.com>

I don't think you built the driver after making this change, otherwise
all of the build warnings you just added would have hinted that this fix
was not correct :(

Please be more careful in the future and always test your patches before
sending them out.

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to