On Thu, Feb 06, 2014 at 12:10:36AM +0800, Zhao, Gang wrote: > fix make W=1 warning: > drivers/staging/et131x/et131x.c: In function > ‘et1310_setup_device_for_multicast’: > drivers/staging/et131x/et131x.c:1052:6: warning: variable ‘pm_csr’ set but > not used [-Wunused-but-set-variable] > u32 pm_csr; > ^ > drivers/staging/et131x/et131x.c: In function > ‘et1310_setup_device_for_unicast’: > drivers/staging/et131x/et131x.c:1101:6: warning: variable ‘pm_csr’ set but > not used [-Wunused-but-set-variable] > u32 pm_csr; > ^ > drivers/staging/et131x/et131x.c: In function ‘et131x_isr_handler’: > drivers/staging/et131x/et131x.c:4006:8: warning: variable ‘pm_csr’ set but > not used [-Wunused-but-set-variable] > u32 pm_csr; > ^ > > Signed-off-by: Zhao, Gang <gamer...@gmail.com> > --- > drivers/staging/et131x/et131x.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c > index 6413500..0c44014 100644 > --- a/drivers/staging/et131x/et131x.c > +++ b/drivers/staging/et131x/et131x.c > @@ -1049,7 +1049,6 @@ static void et1310_setup_device_for_multicast(struct > et131x_adapter *adapter) > u32 hash2 = 0; > u32 hash3 = 0; > u32 hash4 = 0; > - u32 pm_csr; > > /* If ET131X_PACKET_TYPE_MULTICAST is specified, then we provision > * the multi-cast LIST. If it is NOT specified, (and "ALL" is not > @@ -1083,7 +1082,6 @@ static void et1310_setup_device_for_multicast(struct > et131x_adapter *adapter) > } > > /* Write out the new hash to the device */ > - pm_csr = readl(&adapter->regs->global.pm_csr);
Some types of hardware require a read in order to do something, are you sure that this hardware doesn't also need this? Have you tested the code with this change? thanks, greg k-h _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
