On Wed, Jan 08, K. Y. Srinivasan wrote:

> +++ b/tools/hv/hv_fcopy_daemon.c

> +             len = pread(fcopy_fd, buffer, (4096 * 2), 0);
> +
> +             if (len <= 0) {
> +                     syslog(LOG_ERR, "Read error: %s\n", strerror(errno));
> +                     continue;

This could flood syslog. I think the error should be logged just once.
Maybe like this:

        if (len <=0) {
                if (!error) {
                        syslog(...);
                        error = HV_ERROR_NOT_SUPPORTED;
                }
                continue;
        }

> +             }
> +             in_msg = (struct hv_fcopy_hdr *)buffer;
> +
> +             switch (in_msg->operation) {
> +             case START_FILE_COPY:
> +                     error = hv_start_fcopy((struct hv_start_fcopy *)in_msg);

Olaf
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to