The return variable of request_code_segment() is used uninitialized if
the argument boot_case is false, this patch fixes it.

FYI, in ft1000_usb.h: STATUS_SUCCESS 0, and STATUS_FAILURE 0x1001.

Signed-off-by: Adam Lee <adam8...@gmail.com>
---
 drivers/staging/ft1000/ft1000-usb/ft1000_download.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c 
b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
index 68ded17..bda5719 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
@@ -601,11 +601,11 @@ static int request_code_segment(struct ft1000_usb 
*ft1000dev, u16 **s_file,
                status = write_blk(ft1000dev, s_file, c_file, word_length);
                /*DEBUG("write_blk returned %d\n", status); */
        } else {
-               write_blk_fifo(ft1000dev, s_file, c_file, word_length);
+               status = write_blk_fifo(ft1000dev, s_file, c_file, word_length);
                if (ft1000dev->usbboot == 0)
                        ft1000dev->usbboot++;
                if (ft1000dev->usbboot == 1)
-                       ft1000_write_dpram16(ft1000dev,
+                       status |= ft1000_write_dpram16(ft1000dev,
                                        DWNLD_MAG1_PS_HDR_LOC, 0, 0);
        }
        return status;
-- 
1.8.4.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to