On 2013-07-29 21:47, H Hartley Sweeten wrote:
Remove the disabled interrupt support code. This driver always uses a timer with DMA due to the hardware dropping samples when interrrupts are used.Cleanup the boardinfo to just contain the necessary board specific information. Tidy up the driver. H Hartley Sweeten (38): staging: comedi: das16: "timer_mode" is always used for DMA staging: comedi: das16: remove DMA irq support staging: comedi: das16: fix DMA init during board attach staging: comedi: das16: all supported board have analog inputs staging: comedi: das16: change boardinfo 'ai_nbits' to 'ai_maxdata' staging: comedi: das16: all supported board have digital inputs staging: comedi: das16: all supported board have digital outputs staging: comedi: das16: cleanup analog output subdevice staging: comedi: das16: tidy up the comedi_lrange tables staging: comedi: das16: remove unused struct definition staging: comedi: das16: remove 'ai_unipolar' and 'ai_singleended' staging: comedi: das16: remove reg_dump() staging: comedi: das16: remove DEBUG_PRINT macro staging: comedi: das16: remove 'volatile' on private data variables staging: comedi: das16: add a 'can_burst' flag to the private data staging: comedi: das16: remove unused DAS16_SIZE staging: comedi: das16: remove unused static const variable staging: comedi: das16: remove the register map comments staging: comedi: das16: introduce das16_ai_{en,dis}able() helpers staging: comedi: das16: tidy up das16_ai_insn_read() staging: comedi: das16: move some functions to improve readability staging: comedi: das16: remove unnecessary test in das16_interrupt() staging: comedi: das16: move boardinfo declaration staging: comedi: das16: remove 'i8254_offset' from boardinfo staging: comedi: das16: tidy up 8255 digital i/o subdevice staging: comedi: das16: tidy up the register map defines staging: comedi: das16: fail attach if board id is incorrect staging: comedi: das16: cleanup printk message in board attach staging: comedi: das16: absorb das1600_mode_detect() into caller staging: comedi: das16: fix a > 80 char line issue staging: comedi: das16: cleanup comedi_error() messages staging: comedi: das16: tidy up private data definition staging: comedi: das16: change MODULE_DESCRIPTION staging: comedi: das16: fix das16_detach() staging: comedi: das16: remove an unnecessary check in the attach staging: comedi: das16: tidy up user ai/ao range initialization staging: comedi: das16: remove some unnecessary parentheses staging: comedi: das16: tidy up multi-line comments drivers/staging/comedi/drivers/das16.c | 2022 +++++++++++++------------------- 1 file changed, 806 insertions(+), 1216 deletions(-)
Looks okay, although the 'can_burst' flag could be put in struct das16_board and initialized statically.
Reviewed-by: Ian Abbott <abbo...@mev.co.uk> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
