On Fri, Aug 29, 2014 at 12:12:45PM +0200, David Herrmann wrote: [...] > diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c [...] > module_init(udl_init); > module_exit(udl_exit); > +MODULE_LICENSE("GPL");
According to the header file the license is GPL v2 only, so this should be "GPL v2". Might also be good to add MODULE_AUTHOR and MODULE_DESCRIPTION here. Other than that: Reviewed-by: Thierry Reding <treding at nvidia.com> -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/8960541a/attachment.sig>