Just noticed two other things:
On Tue, Aug 19, 2014 at 05:10:51PM +0800, Y.C. Chen wrote:
> --- a/drivers/gpu/drm/ast/ast_tables.h
> +++ b/drivers/gpu/drm/ast/ast_tables.h
> @@ -72,6 +72,7 @@
> static struct ast_vbios_dclk_info dclk_table[] = {
> {0x2C, 0xE7, 0x03}, /* 00:
> VCLK25_175 */
> @@ -99,6 +100,8 @@ static struct ast_vbios_dclk_info dclk_table[] = {
> {0x25, 0x65, 0x80}, /* 16:
> VCLK88.75 */
> {0x77, 0x58, 0x80}, /* 17: VCLK119
> */
> {0x32, 0x67, 0x80}, /* 18: VCLK85_5
> */
> + {0x6a, 0x6d, 0x80}, /* 19:
> VCLK97_75 */
This addition fixes another bug: without this entry the unpatched code may run
off the end of the list.
Maybe you can provide this addition (just this one line) in a separate
patch, explaining in the changelog what it fixes.
> + {0x3b, 0x2c, 0x81}, /* 1A:
> VCLK118_25 */
> };
>
> /* 16:10 */
> static struct ast_vbios_enhtable res_1280x800[] = {
> - {1440, 1280, 48, 32, 823, 800, 3, 6, VCLK71, /* 60Hz RB */
> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo),
> 60, 1, 35 },
> - {1680, 1280, 72,128, 831, 800, 3, 6, VCLK83_5, /* 60Hz */
> - (SyncPN | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo),
> 60, 1, 0x35 },
> - {1680, 1280, 72,128, 831, 800, 3, 6, VCLK83_5, /* 60Hz */
> - (SyncPN | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo),
> 0xFF, 1, 0x35 },
> -
> + {1680, 1280, 72,128, 831, 800, 3, 6, VCLK83_5, /* 60Hz CVT */
> + (SyncPN | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo),
> 60, 1, 0x35 },
> + {1440, 1280, 48, 32, 823, 800, 3, 6, VCLK71, /* 60Hz CVT RB
> */
> + (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo),
> 60, 2, 35 },
_______^^
This was like this in the code before - but shouldn't this
read: 0x35?
> + {1440, 1280, 48, 32, 823, 800, 3, 6, VCLK71, /* 60Hz CVT RB
> */
> + (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo),
> 0xFF, 2, 35 },
_______^^
Same
here.
