On Tue, Apr 8, 2014 at 9:09 AM, Christian K?nig <deathsimple at vodafone.de> wrote: > Am 08.04.2014 15:04, schrieb Alex Deucher: > >> On Tue, Apr 8, 2014 at 4:03 AM, Daniel Vetter <daniel at ffwll.ch> wrote: >>> >>> On Tue, Apr 8, 2014 at 8:58 AM, Jani Nikula <jani.nikula at intel.com> >>> wrote: >>>> >>>> Before the conversion to dp aux helpers there was a switch case [1] that >>>> ended up in msg_bytes = 3 for address only start/stop messages >>>> (MODE_I2C_START or MODE_I2C_STOP bit set [2]). With Alex's series in, >>>> but without my patch, we'd send the four byte header but with 0 - 1 = >>>> 0xff in txbuf[3]. I'm pretty sure breakage would follow. >>>> >>>> Thus I'd like to have my patch in before the dp aux helpers use >>>> msg->size == 0 for address only messages. >>>> >>>> Daniel, convinced yet? >>> >>> Indeed, I've been blinding. Acked for merging through radeon trees >>> together with the other patches as a fixup for 3.15. >> >> Christian, >> >> Can you pull this into the radeon 3.15 branch as well? > > > Sure, directly before your other patches I would assume.
yes. > > Going to send out the pull request to Dave this evening if nobody objects. > Sounds good to me. Thanks! Alex > Christian. > >> >> Thanks, >> >> Alex > >
